From 4172d8edc11d2ee027b61555f2845b3fcb770ae9 Mon Sep 17 00:00:00 2001 From: ishaanJ91 Date: Tue, 24 Jun 2025 15:53:54 +0400 Subject: [PATCH] Fix: create screenshot directory if missing before saving files --- electron/ScreenshotHelper.ts | 289 ++++++++++++++++++++--------------- 1 file changed, 163 insertions(+), 126 deletions(-) diff --git a/electron/ScreenshotHelper.ts b/electron/ScreenshotHelper.ts index 0702b06..74d6135 100644 --- a/electron/ScreenshotHelper.ts +++ b/electron/ScreenshotHelper.ts @@ -1,48 +1,55 @@ // ScreenshotHelper.ts -import path from "node:path" -import fs from "node:fs" -import { app } from "electron" -import { v4 as uuidv4 } from "uuid" -import { execFile } from "child_process" -import { promisify } from "util" -import screenshot from "screenshot-desktop" -import os from "os" +import path from "node:path"; +import fs from "node:fs"; +import { app } from "electron"; +import { v4 as uuidv4 } from "uuid"; +import { execFile } from "child_process"; +import { promisify } from "util"; +import screenshot from "screenshot-desktop"; +import os from "os"; -const execFileAsync = promisify(execFile) +const execFileAsync = promisify(execFile); export class ScreenshotHelper { - private screenshotQueue: string[] = [] - private extraScreenshotQueue: string[] = [] - private readonly MAX_SCREENSHOTS = 5 + private screenshotQueue: string[] = []; + private extraScreenshotQueue: string[] = []; + private readonly MAX_SCREENSHOTS = 5; - private readonly screenshotDir: string - private readonly extraScreenshotDir: string - private readonly tempDir: string + private readonly screenshotDir: string; + private readonly extraScreenshotDir: string; + private readonly tempDir: string; - private view: "queue" | "solutions" | "debug" = "queue" + private view: "queue" | "solutions" | "debug" = "queue"; constructor(view: "queue" | "solutions" | "debug" = "queue") { - this.view = view + this.view = view; // Initialize directories - this.screenshotDir = path.join(app.getPath("userData"), "screenshots") + this.screenshotDir = path.join(app.getPath("userData"), "screenshots"); this.extraScreenshotDir = path.join( app.getPath("userData"), "extra_screenshots" - ) - this.tempDir = path.join(app.getPath("temp"), "interview-coder-screenshots") + ); + this.tempDir = path.join( + app.getPath("temp"), + "interview-coder-screenshots" + ); // Create directories if they don't exist this.ensureDirectoriesExist(); - + // Clean existing screenshot directories when starting the app this.cleanScreenshotDirectories(); } - + private ensureDirectoriesExist(): void { - const directories = [this.screenshotDir, this.extraScreenshotDir, this.tempDir]; - + const directories = [ + this.screenshotDir, + this.extraScreenshotDir, + this.tempDir, + ]; + for (const dir of directories) { if (!fs.existsSync(dir)) { try { @@ -54,16 +61,17 @@ export class ScreenshotHelper { } } } - + // This method replaces loadExistingScreenshots() to ensure we start with empty queues private cleanScreenshotDirectories(): void { try { // Clean main screenshots directory if (fs.existsSync(this.screenshotDir)) { - const files = fs.readdirSync(this.screenshotDir) - .filter(file => file.endsWith('.png')) - .map(file => path.join(this.screenshotDir, file)); - + const files = fs + .readdirSync(this.screenshotDir) + .filter((file) => file.endsWith(".png")) + .map((file) => path.join(this.screenshotDir, file)); + // Delete each screenshot file for (const file of files) { try { @@ -74,13 +82,14 @@ export class ScreenshotHelper { } } } - + // Clean extra screenshots directory if (fs.existsSync(this.extraScreenshotDir)) { - const files = fs.readdirSync(this.extraScreenshotDir) - .filter(file => file.endsWith('.png')) - .map(file => path.join(this.extraScreenshotDir, file)); - + const files = fs + .readdirSync(this.extraScreenshotDir) + .filter((file) => file.endsWith(".png")) + .map((file) => path.join(this.extraScreenshotDir, file)); + // Delete each screenshot file for (const file of files) { try { @@ -91,7 +100,7 @@ export class ScreenshotHelper { } } } - + console.log("Screenshot directories cleaned successfully"); } catch (err) { console.error("Error cleaning screenshot directories:", err); @@ -99,27 +108,27 @@ export class ScreenshotHelper { } public getView(): "queue" | "solutions" | "debug" { - return this.view + return this.view; } public setView(view: "queue" | "solutions" | "debug"): void { - console.log("Setting view in ScreenshotHelper:", view) + console.log("Setting view in ScreenshotHelper:", view); console.log( "Current queues - Main:", this.screenshotQueue, "Extra:", this.extraScreenshotQueue - ) - this.view = view + ); + this.view = view; } public getScreenshotQueue(): string[] { - return this.screenshotQueue + return this.screenshotQueue; } public getExtraScreenshotQueue(): string[] { - console.log("Getting extra screenshot queue:", this.extraScreenshotQueue) - return this.extraScreenshotQueue + console.log("Getting extra screenshot queue:", this.extraScreenshotQueue); + return this.extraScreenshotQueue; } public clearQueues(): void { @@ -127,10 +136,10 @@ export class ScreenshotHelper { this.screenshotQueue.forEach((screenshotPath) => { fs.unlink(screenshotPath, (err) => { if (err) - console.error(`Error deleting screenshot at ${screenshotPath}:`, err) - }) - }) - this.screenshotQueue = [] + console.error(`Error deleting screenshot at ${screenshotPath}:`, err); + }); + }); + this.screenshotQueue = []; // Clear extraScreenshotQueue this.extraScreenshotQueue.forEach((screenshotPath) => { @@ -139,25 +148,27 @@ export class ScreenshotHelper { console.error( `Error deleting extra screenshot at ${screenshotPath}:`, err - ) - }) - }) - this.extraScreenshotQueue = [] + ); + }); + }); + this.extraScreenshotQueue = []; } private async captureScreenshot(): Promise { try { console.log("Starting screenshot capture..."); - + // For Windows, try multiple methods - if (process.platform === 'win32') { + if (process.platform === "win32") { return await this.captureWindowsScreenshot(); - } - + } + // For macOS and Linux, use buffer directly console.log("Taking screenshot on non-Windows platform"); - const buffer = await screenshot({ format: 'png' }); - console.log(`Screenshot captured successfully, size: ${buffer.length} bytes`); + const buffer = await screenshot({ format: "png" }); + console.log( + `Screenshot captured successfully, size: ${buffer.length} bytes` + ); return buffer; } catch (error) { console.error("Error capturing screenshot:", error); @@ -170,25 +181,29 @@ export class ScreenshotHelper { */ private async captureWindowsScreenshot(): Promise { console.log("Attempting Windows screenshot with multiple methods"); - + // Method 1: Try screenshot-desktop with filename first try { const tempFile = path.join(this.tempDir, `temp-${uuidv4()}.png`); - console.log(`Taking Windows screenshot to temp file (Method 1): ${tempFile}`); - + console.log( + `Taking Windows screenshot to temp file (Method 1): ${tempFile}` + ); + await screenshot({ filename: tempFile }); - + if (fs.existsSync(tempFile)) { const buffer = await fs.promises.readFile(tempFile); - console.log(`Method 1 successful, screenshot size: ${buffer.length} bytes`); - + console.log( + `Method 1 successful, screenshot size: ${buffer.length} bytes` + ); + // Cleanup temp file try { await fs.promises.unlink(tempFile); } catch (cleanupErr) { console.warn("Failed to clean up temp file:", cleanupErr); } - + return buffer; } else { console.log("Method 1 failed: File not created"); @@ -196,12 +211,12 @@ export class ScreenshotHelper { } } catch (error) { console.warn("Windows screenshot Method 1 failed:", error); - + // Method 2: Try using PowerShell try { console.log("Attempting Windows screenshot with PowerShell (Method 2)"); const tempFile = path.join(this.tempDir, `ps-temp-${uuidv4()}.png`); - + // PowerShell command to take screenshot using .NET classes const psScript = ` Add-Type -AssemblyName System.Windows.Forms,System.Drawing @@ -214,46 +229,60 @@ export class ScreenshotHelper { $bmp = New-Object System.Drawing.Bitmap $bounds.Width, $bounds.Height $graphics = [System.Drawing.Graphics]::FromImage($bmp) $graphics.CopyFromScreen($bounds.Left, $bounds.Top, 0, 0, $bounds.Size) - $bmp.Save('${tempFile.replace(/\\/g, '\\\\')}', [System.Drawing.Imaging.ImageFormat]::Png) + $bmp.Save('${tempFile.replace( + /\\/g, + "\\\\" + )}', [System.Drawing.Imaging.ImageFormat]::Png) $graphics.Dispose() $bmp.Dispose() `; - + // Execute PowerShell - await execFileAsync('powershell', [ - '-NoProfile', - '-ExecutionPolicy', 'Bypass', - '-Command', psScript + await execFileAsync("powershell", [ + "-NoProfile", + "-ExecutionPolicy", + "Bypass", + "-Command", + psScript, ]); - + // Check if file exists and read it if (fs.existsSync(tempFile)) { const buffer = await fs.promises.readFile(tempFile); - console.log(`Method 2 successful, screenshot size: ${buffer.length} bytes`); - + console.log( + `Method 2 successful, screenshot size: ${buffer.length} bytes` + ); + // Cleanup try { await fs.promises.unlink(tempFile); } catch (err) { console.warn("Failed to clean up PowerShell temp file:", err); } - + return buffer; } else { throw new Error("PowerShell screenshot file not created"); } } catch (psError) { console.warn("Windows PowerShell screenshot failed:", psError); - + // Method 3: Last resort - create a tiny placeholder image - console.log("All screenshot methods failed, creating placeholder image"); - + console.log( + "All screenshot methods failed, creating placeholder image" + ); + // Create a 1x1 transparent PNG as fallback - const fallbackBuffer = Buffer.from('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=', 'base64'); + const fallbackBuffer = Buffer.from( + "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=", + "base64" + ); console.log("Created placeholder image as fallback"); - + // Show the error but return a valid buffer so the app doesn't crash - throw new Error("Could not capture screenshot with any method. Please check your Windows security settings and try again."); + throw new Error( + "Could not capture screenshot with any method. Please check your Windows security settings and try again." + ); } } } @@ -262,87 +291,95 @@ export class ScreenshotHelper { hideMainWindow: () => void, showMainWindow: () => void ): Promise { - console.log("Taking screenshot in view:", this.view) - hideMainWindow() - + console.log("Taking screenshot in view:", this.view); + hideMainWindow(); + // Increased delay for window hiding on Windows - const hideDelay = process.platform === 'win32' ? 500 : 300; - await new Promise((resolve) => setTimeout(resolve, hideDelay)) + const hideDelay = process.platform === "win32" ? 500 : 300; + await new Promise((resolve) => setTimeout(resolve, hideDelay)); - let screenshotPath = "" + let screenshotPath = ""; try { // Get screenshot buffer using cross-platform method const screenshotBuffer = await this.captureScreenshot(); - + if (!screenshotBuffer || screenshotBuffer.length === 0) { throw new Error("Screenshot capture returned empty buffer"); } // Save and manage the screenshot based on current view if (this.view === "queue") { - screenshotPath = path.join(this.screenshotDir, `${uuidv4()}.png`) - await fs.promises.writeFile(screenshotPath, screenshotBuffer) - console.log("Adding screenshot to main queue:", screenshotPath) - this.screenshotQueue.push(screenshotPath) + screenshotPath = path.join(this.screenshotDir, `${uuidv4()}.png`); + const screenshotDir = path.dirname(screenshotPath); + if (!fs.existsSync(screenshotDir)) { + fs.mkdirSync(screenshotDir, { recursive: true }); + } + await fs.promises.writeFile(screenshotPath, screenshotBuffer); + console.log("Adding screenshot to main queue:", screenshotPath); + this.screenshotQueue.push(screenshotPath); if (this.screenshotQueue.length > this.MAX_SCREENSHOTS) { - const removedPath = this.screenshotQueue.shift() + const removedPath = this.screenshotQueue.shift(); if (removedPath) { try { - await fs.promises.unlink(removedPath) + await fs.promises.unlink(removedPath); console.log( "Removed old screenshot from main queue:", removedPath - ) + ); } catch (error) { - console.error("Error removing old screenshot:", error) + console.error("Error removing old screenshot:", error); } } } } else { // In solutions view, only add to extra queue - screenshotPath = path.join(this.extraScreenshotDir, `${uuidv4()}.png`) - await fs.promises.writeFile(screenshotPath, screenshotBuffer) - console.log("Adding screenshot to extra queue:", screenshotPath) - this.extraScreenshotQueue.push(screenshotPath) + screenshotPath = path.join(this.extraScreenshotDir, `${uuidv4()}.png`); + const screenshotDir = path.dirname(screenshotPath); + if (!fs.existsSync(screenshotDir)) { + fs.mkdirSync(screenshotDir, { recursive: true }); + } + await fs.promises.writeFile(screenshotPath, screenshotBuffer); + console.log("Adding screenshot to extra queue:", screenshotPath); + this.extraScreenshotQueue.push(screenshotPath); if (this.extraScreenshotQueue.length > this.MAX_SCREENSHOTS) { - const removedPath = this.extraScreenshotQueue.shift() + const removedPath = this.extraScreenshotQueue.shift(); if (removedPath) { try { - await fs.promises.unlink(removedPath) + await fs.promises.unlink(removedPath); console.log( "Removed old screenshot from extra queue:", removedPath - ) + ); } catch (error) { - console.error("Error removing old screenshot:", error) + console.error("Error removing old screenshot:", error); } } } } } catch (error) { - console.error("Screenshot error:", error) - throw error + console.error("Screenshot error:", error); + throw error; } finally { // Increased delay for showing window again - await new Promise((resolve) => setTimeout(resolve, 200)) - showMainWindow() + await new Promise((resolve) => setTimeout(resolve, 200)); + showMainWindow(); } - return screenshotPath + return screenshotPath; } public async getImagePreview(filepath: string): Promise { try { if (!fs.existsSync(filepath)) { console.error(`Image file not found: ${filepath}`); - return ''; + return ""; } - - const data = await fs.promises.readFile(filepath) - return `data:image/png;base64,${data.toString("base64")}` + + const data = await fs.promises.readFile(filepath); + return `data:image/png;base64,${data.toString("base64")}`; } catch (error) { - console.error("Error reading image:", error) - return '' + console.error("Error reading image:", error); + return ""; } } @@ -351,22 +388,22 @@ export class ScreenshotHelper { ): Promise<{ success: boolean; error?: string }> { try { if (fs.existsSync(path)) { - await fs.promises.unlink(path) + await fs.promises.unlink(path); } - + if (this.view === "queue") { this.screenshotQueue = this.screenshotQueue.filter( (filePath) => filePath !== path - ) + ); } else { this.extraScreenshotQueue = this.extraScreenshotQueue.filter( (filePath) => filePath !== path - ) + ); } - return { success: true } + return { success: true }; } catch (error) { - console.error("Error deleting file:", error) - return { success: false, error: error.message } + console.error("Error deleting file:", error); + return { success: false, error: error.message }; } } @@ -379,10 +416,10 @@ export class ScreenshotHelper { console.error( `Error deleting extra screenshot at ${screenshotPath}:`, err - ) - }) + ); + }); } - }) - this.extraScreenshotQueue = [] + }); + this.extraScreenshotQueue = []; } }